Page MenuHomePhabricator

Make "bin/files" parsing of working set arguments more consistent
ClosedPublic

Authored by epriestley on Jun 24 2019, 10:13 PM.
Tags
None
Referenced Files
F18831376: D20614.diff
Sat, Oct 25, 12:38 PM
F18802977: D20614.id.diff
Fri, Oct 17, 9:07 PM
F18763670: D20614.id49176.diff
Tue, Oct 7, 1:25 AM
F18755074: D20614.id49179.diff
Sun, Oct 5, 3:27 AM
F18755039: D20614.id.diff
Sun, Oct 5, 3:21 AM
F18741514: D20614.id49176.diff
Thu, Oct 2, 1:36 PM
F18671591: D20614.diff
Sep 25 2025, 4:28 AM
F18652385: D20614.diff
Sep 21 2025, 7:53 AM
Subscribers
None

Details

Summary

Fixes T13326. In D20571, I slightly generalized construction of an iterator over a set of files, but missed some code in other "bin/files ..." commands which was also affected.

Today, basically all of these workflows define their own "--all" and "names" flags. Pull these definitions up and implement them more consistently.

Test Plan

Ran multiple different bin/files commands with different combinations of arguments, saw consistent handling of iterator construction.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable