remote information
ClosedPublic
Actions

Authored by epriestley on Jun 20 2019, 9:36 PM.

Details

Reviewers

Maniphest Tasks

T11037: `bin/phd status` is misleading about local / remote daemons
T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date

Commits

rP08b9e70bea5c: Make "bin/phd status" report local daemons from the process list, not a mess of…

Summary

Ref T13321. Fixes T11037. Realign "bin/phd status" to just mean "show daemon processes on this host".

The value of bin/phd status as a mixed remote/local command isn't clear, and the current output is a confusing mess (see T11037).

This also continues letting us move away from PID files.

Test Plan

Ran bin/phd status, saw sensible local process status.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 20 2019, 9:36 PM

Harbormaster completed remote builds in B23012: Diff 49140.Jun 20 2019, 9:37 PM

epriestley requested review of this revision.Jun 20 2019, 9:37 PM

epriestley mentioned this in T11037: `bin/phd status` is misleading about local / remote daemons.Jun 20 2019, 9:37 PM

amckinley accepted this revision.Jun 20 2019, 10:38 PM

This revision is now accepted and ready to land.Jun 20 2019, 10:38 PM

Closed by commit rP08b9e70bea5c: Make "bin/phd status" report local daemons from the process list, not a mess of… (authored by epriestley). · Explain WhyJun 24 2019, 6:26 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP08b9e70bea5c: Make "bin/phd status" report local daemons from the process list, not a mess of….

Revision Contents
Changeset List

Path

Size

src/

applications/

daemon/

management/

PhabricatorDaemonManagementStatusWorkflow.php

115 lines

PhabricatorDaemonManagementWorkflow.php

25 lines

Diff 49170

View Options

src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php