Page MenuHomePhabricator
Differential D20604

Make "bin/phd status" report local daemons from the process list, not a mess of local/remote information
ClosedPublic
Actions

Authored by epriestley on Jun 20 2019, 9:36 PM.
Tags
None
Referenced Files
F15462307: D20604.id49170.diff
Tue, Apr 1, 1:54 PM
F15449815: D20604.id.diff
Fri, Mar 28, 12:22 PM
F15431625: D20604.id.diff
Mon, Mar 24, 1:33 PM
F15428779: D20604.diff
Sun, Mar 23, 10:17 PM
F15418166: D20604.id49140.diff
Thu, Mar 20, 9:17 PM
F15398426: D20604.diff
Mon, Mar 17, 12:05 AM
F15382547: D20604.diff
Fri, Mar 14, 1:00 PM
F15343490: D20604.id49170.diff
Mar 9 2025, 11:11 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T11037: `bin/phd status` is misleading about local / remote daemons
T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date
Commits
rP08b9e70bea5c: Make "bin/phd status" report local daemons from the process list, not a mess of…
Summary

Ref T13321. Fixes T11037. Realign "bin/phd status" to just mean "show daemon processes on this host".

The value of bin/phd status as a mixed remote/local command isn't clear, and the current output is a confusing mess (see T11037).

This also continues letting us move away from PID files.

Test Plan

Ran bin/phd status, saw sensible local process status.

Diff Detail

Repository
rP Phabricator
Branch
pquery5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23012
Build 31593: Run Core Tests
Build 31592: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
daemon/
management/
115 lines
25 lines

Diff 49140

View Options

src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php

Loading...
View Options

src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php

Loading...
Phabricator · Built by Phacility