Paths

Table of Contentst

Differential D20596

Fix an issue in Owners where a transaction change could show too many effects
ClosedPublic
Actions

Authored by epriestley on Jun 20 2019, 6:16 PM.

Tags

None

Referenced Files

	F13218153: D20596.id49129.diff
	Sat, May 18, 10:27 AM

	F13214771: D20596.id49151.diff
	Fri, May 17, 12:48 PM

	F13214336: D20596.id49129.diff
	Fri, May 17, 9:57 AM

	F13211651: D20596.diff
	Fri, May 17, 5:57 AM

	F13209275: D20596.id49151.diff
	Thu, May 16, 11:02 PM

	F13195336: D20596.diff
	Sun, May 12, 10:18 PM

	F13179458: D20596.diff
	Wed, May 8, 9:13 PM

	Unknown Object (File)
	Tue, May 7, 4:46 AM

Subscribers

None

Tokens

"Love" token, awarded by kylec.

Details

Reviewers

Maniphest Tasks

T13324: Owners transactions which edit paths for packages with one or more paths with no trailing slash render incorrectly

Commits

rP53f8ad14fa92: Fix an issue in Owners where a transaction change could show too many effects

Summary

Fixes T13324. Ref PHI1288. Currently, if you edit an Owners package that has some paths with no trailing slashes (like README.md) so their internal names and display names differ (/README.md display, vs /README.md/ internal), the "Show Details" in the transaction log shows the path as re-normalized even if you didn't touch it.

Instead, be more careful about handling display paths vs internal paths.

(This code on the whole is significantly less clear than it probably could be, but this issue is so minor that I'm hesitant to start ripping things out.)

Test Plan

In a package with some paths like /src/ and some paths like /src:
Added new paths.
Removed paths.
Changed paths from /src/ to /src.
Changed paths from /src to /src/.

In all cases, the "paths" list and the transaction record identically reflected the edit in the way I expected them to.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 20 2019, 6:16 PM

Harbormaster completed remote builds in B23001: Diff 49129.Jun 20 2019, 6:17 PM

epriestley requested review of this revision.Jun 20 2019, 6:17 PM

kylec awarded a token.Jun 20 2019, 7:20 PM

amckinley accepted this revision.Jun 20 2019, 10:54 PM

This revision is now accepted and ready to land.Jun 20 2019, 10:54 PM

Closed by commit rP53f8ad14fa92: Fix an issue in Owners where a transaction change could show too many effects (authored by epriestley). · Explain WhyJun 20 2019, 11:08 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP53f8ad14fa92: Fix an issue in Owners where a transaction change could show too many effects.

Revision Contents
Changeset List

Path

Size

src/

applications/

owners/

storage/

PhabricatorOwnersPath.php

16 lines

xaction/

PhabricatorOwnersPackagePathsTransaction.php

36 lines

Diff 49151

src/applications/owners/storage/PhabricatorOwnersPath.php

Loading...

src/applications/owners/xaction/PhabricatorOwnersPackagePathsTransaction.php

Loading...