Page MenuHomePhabricator
Differential D20608

Remove "phd.pid-directory" configuration and stop passing "piddir" to daemons
ClosedPublic
Actions

Authored by epriestley on Jun 20 2019, 10:11 PM.
Tags
None
Referenced Files
F19083014: D20608.id49173.diff
Dec 2 2025, 12:29 PM
F18985143: D20608.id49145.diff
Nov 17 2025, 12:54 PM
F18952700: D20608.diff
Nov 12 2025, 6:24 AM
F18877765: D20608.id.diff
Nov 6 2025, 11:53 AM
F18875463: D20608.diff
Nov 5 2025, 6:04 PM
F18766179: D20608.diff
Oct 7 2025, 3:20 PM
F18764593: D20608.id49173.diff
Oct 7 2025, 6:46 AM
F18761023: D20608.id.diff
Oct 6 2025, 11:56 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date
Commits
rP65bc481c91de: Remove "phd.pid-directory" configuration and stop passing "piddir" to daemons
Summary

Ref T13321. The daemons no longer write PID files, so we no longer need to pass any of this stuff to them.

Test Plan

Grepped for affected symbols.

Diff Detail

Repository
rP Phabricator
Branch
pquery9
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/daemon/control/PhabricatorDaemonReference.php:3XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 23017
Build 31603: Run Core Tests
Build 31602: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 20 2019, 10:11 PM
Harbormaster completed remote builds in B23017: Diff 49145.Jun 20 2019, 10:12 PM
epriestley requested review of this revision.Jun 20 2019, 10:12 PM
amckinley accepted this revision.Jun 20 2019, 10:52 PM
amckinley added inline comments.
src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php
151

Mission accomplished!

This revision is now accepted and ready to land.Jun 20 2019, 10:52 PM
Closed by commit rP65bc481c91de: Remove "phd.pid-directory" configuration and stop passing "piddir" to daemons (authored by epriestley). · Explain WhyJun 24 2019, 6:29 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP65bc481c91de: Remove "phd.pid-directory" configuration and stop passing "piddir" to daemons.

Revision Contents
Changeset List

PathSize
src/
applications/
config/
check/
3 lines
option/
4 lines
daemon/
management/
16 lines
infrastructure/
daemon/
control/
135 lines

Diff 49145

View Options

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php

Loading...
View Options

src/applications/config/option/PhabricatorPHDConfigOptions.php

Loading...
View Options

src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php

Loading...
View Options

src/infrastructure/daemon/control/PhabricatorDaemonReference.php

Loading...
Phabricator · Built by Phacility