Page MenuHomePhabricator

Remove "phd.pid-directory" configuration and stop passing "piddir" to daemons
ClosedPublic

Authored by epriestley on Jun 20 2019, 10:11 PM.

Details

Summary

Ref T13321. The daemons no longer write PID files, so we no longer need to pass any of this stuff to them.

Test Plan

Grepped for affected symbols.

Diff Detail

Repository
rP Phabricator
Branch
pquery9
Lint
Lint OK
SeverityLocationCodeMessage
Advicesrc/infrastructure/daemon/control/PhabricatorDaemonReference.php:3XHP16TODO Comment
Unit
Unit Tests OK
Build Status
Buildable 23017
Build 31603: Run Core Tests
Build 31602: arc lint + arc unit

Event Timeline

amckinley added inline comments.
src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php
151

Mission accomplished!

This revision is now accepted and ready to land.Jun 20 2019, 10:52 PM