Page MenuHomePhabricator

Remove "phd.pid-directory" configuration and stop passing "piddir" to daemons
ClosedPublic

Authored by epriestley on Jun 20 2019, 10:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 2, 10:35 AM
Unknown Object (File)
Feb 14 2024, 9:51 PM
Unknown Object (File)
Dec 30 2023, 6:20 PM
Unknown Object (File)
Dec 26 2023, 8:17 PM
Unknown Object (File)
Dec 23 2023, 10:39 PM
Unknown Object (File)
Dec 22 2023, 2:27 AM
Unknown Object (File)
Dec 4 2023, 3:27 PM
Unknown Object (File)
Nov 29 2023, 11:49 PM
Subscribers
None

Details

Summary

Ref T13321. The daemons no longer write PID files, so we no longer need to pass any of this stuff to them.

Test Plan

Grepped for affected symbols.

Diff Detail

Repository
rP Phabricator
Branch
pquery9
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/daemon/control/PhabricatorDaemonReference.php:3XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 23017
Build 31603: Run Core Tests
Build 31602: arc lint + arc unit

Event Timeline

amckinley added inline comments.
src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php
151

Mission accomplished!

This revision is now accepted and ready to land.Jun 20 2019, 10:52 PM