Page MenuHomePhabricator

Fix an issue in Owners where a transaction change could show too many effects
ClosedPublic

Authored by epriestley on Jun 20 2019, 6:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 7:55 AM
Unknown Object (File)
Sat, Nov 16, 3:12 PM
Unknown Object (File)
Fri, Nov 15, 1:53 PM
Unknown Object (File)
Wed, Nov 6, 4:50 AM
Unknown Object (File)
Mon, Oct 28, 3:02 PM
Unknown Object (File)
Oct 22 2024, 2:17 PM
Unknown Object (File)
Oct 9 2024, 12:25 PM
Unknown Object (File)
Sep 30 2024, 8:26 PM
Subscribers
None
Tokens
"Love" token, awarded by kylec.

Details

Summary

Fixes T13324. Ref PHI1288. Currently, if you edit an Owners package that has some paths with no trailing slashes (like README.md) so their internal names and display names differ (/README.md display, vs /README.md/ internal), the "Show Details" in the transaction log shows the path as re-normalized even if you didn't touch it.

Instead, be more careful about handling display paths vs internal paths.

(This code on the whole is significantly less clear than it probably could be, but this issue is so minor that I'm hesitant to start ripping things out.)

Test Plan
  • In a package with some paths like /src/ and some paths like /src:
  • Added new paths.
  • Removed paths.
  • Changed paths from /src/ to /src.
  • Changed paths from /src to /src/.

In all cases, the "paths" list and the transaction record identically reflected the edit in the way I expected them to.

Diff Detail

Repository
rP Phabricator
Branch
owners1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23001
Build 31571: Run Core Tests
Build 31570: arc lint + arc unit