Page MenuHomePhabricator

Fix missing link targets for "View Object" header buttons in HTML email
ClosedPublic

Authored by epriestley on Jun 18 2019, 2:25 PM.
Tags
None
Referenced Files
F15484742: D20586.id49104.diff
Wed, Apr 9, 7:50 PM
F15478922: D20586.id49112.diff
Tue, Apr 8, 3:58 AM
F15473357: D20586.id.diff
Sat, Apr 5, 9:07 PM
F15470122: D20586.diff
Fri, Apr 4, 8:09 PM
F15452270: D20586.diff
Sat, Mar 29, 3:27 AM
F15430794: D20586.id49104.diff
Mon, Mar 24, 8:59 AM
F15423902: D20586.id49112.diff
Sat, Mar 22, 7:20 PM
F15376916: D20586.id49104.diff
Mar 13 2025, 6:37 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/view-task-from-maniphest-e-mail-doesnt-have-url/2827.

I added "View Task" / "View Commit" buttons recently but the logic for generating URIs isn't quite right. Fix it up.

Test Plan
  • Commented on a task.
  • Used bin/mail show-outbound --id ... --dump-html > out.html to dump the HTML.
  • Previewed the HTML in a browser.
  • This time, actually clicked the button to go to the task.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable