Page MenuHomePhabricator
Differential D20586

Fix missing link targets for "View Object" header buttons in HTML email
ClosedPublic
Actions

Authored by epriestley on Jun 18 2019, 2:25 PM.
Tags
None
Referenced Files
F14123305: D20586.diff
Fri, Nov 29, 9:44 PM
F14120374: D20586.diff
Fri, Nov 29, 8:27 AM
Unknown Object (File)
Tue, Nov 26, 5:15 PM
Unknown Object (File)
Tue, Nov 26, 3:43 PM
Unknown Object (File)
Mon, Nov 25, 12:41 AM
Unknown Object (File)
Mon, Nov 11, 4:52 AM
Unknown Object (File)
Mon, Nov 4, 7:24 AM
Unknown Object (File)
Oct 30 2024, 8:31 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP753828649956: Fix missing link targets for "View Object" header buttons in HTML email
Summary

See https://discourse.phabricator-community.org/t/view-task-from-maniphest-e-mail-doesnt-have-url/2827.

I added "View Task" / "View Commit" buttons recently but the logic for generating URIs isn't quite right. Fix it up.

Test Plan
  • Commented on a task.
  • Used bin/mail show-outbound --id ... --dump-html > out.html to dump the HTML.
  • Previewed the HTML in a browser.
  • This time, actually clicked the button to go to the task.

Diff Detail

Repository
rP Phabricator
Branch
view1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22979
Build 31539: Run Core Tests
Build 31538: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
editor/
3 lines
differential/
editor/
6 lines
maniphest/
editor/
3 lines
transactions/
editor/
32 lines

Diff 49104

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility