Page MenuHomePhabricator

Fix missing link targets for "View Object" header buttons in HTML email
ClosedPublic

Authored by epriestley on Jun 18 2019, 2:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 3:03 PM
Unknown Object (File)
Wed, Apr 17, 8:59 AM
Unknown Object (File)
Mar 23 2024, 12:44 PM
Unknown Object (File)
Mar 23 2024, 12:44 PM
Unknown Object (File)
Mar 4 2024, 10:47 PM
Unknown Object (File)
Feb 20 2024, 10:21 AM
Unknown Object (File)
Feb 7 2024, 3:21 AM
Unknown Object (File)
Jan 25 2024, 12:00 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/view-task-from-maniphest-e-mail-doesnt-have-url/2827.

I added "View Task" / "View Commit" buttons recently but the logic for generating URIs isn't quite right. Fix it up.

Test Plan
  • Commented on a task.
  • Used bin/mail show-outbound --id ... --dump-html > out.html to dump the HTML.
  • Previewed the HTML in a browser.
  • This time, actually clicked the button to go to the task.

Diff Detail

Repository
rP Phabricator
Branch
view1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22979
Build 31539: Run Core Tests
Build 31538: arc lint + arc unit