Differential D20574

Allow "Sign with MFA" to be applied as a comment action without requiring "CAN_EDIT"
ClosedPublic
Actions

Authored by epriestley on Jun 6 2019, 2:23 AM.

Details

Reviewers

amckinley

Maniphest Tasks

T13307: "Sign With MFA" requires "CAN_EDIT" permission, but should only require "CAN_INTERACT" permission

Commits

rPd3112392d1e8: Allow "Sign with MFA" to be applied as a comment action without requiring…

Summary

Fixes T13307. We currently require "CAN_EDIT" to sign actions, but it's fine to sign a comment with only "CAN_INTERACT".

Since the actions like "Accept Revision" already work like this, the fix is one line.

Test Plan

Screen Shot 2019-06-05 at 7.21.16 PM.png (454×638 px, 34 KB)

Diff Detail

Repository

rP Phabricator

Branch

mfa1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22952
Build 31497: Run Core Tests
Build 31496: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 6 2019, 2:23 AM

Harbormaster completed remote builds in B22952: Diff 49077.Jun 6 2019, 2:25 AM

epriestley requested review of this revision.Jun 6 2019, 2:25 AM

Ignore this, test.

amckinley accepted this revision.Jun 17 2019, 5:17 PM

This revision is now accepted and ready to land.Jun 17 2019, 5:17 PM

Closed by commit rPd3112392d1e8: Allow "Sign with MFA" to be applied as a comment action without requiring… (authored by epriestley). · Explain WhyJun 17 2019, 5:41 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPd3112392d1e8: Allow "Sign with MFA" to be applied as a comment action without requiring….

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

engineextension/

PhabricatorAuthMFAEditEngineExtension.php

1 line

Diff 49077

View Options

src/applications/auth/engineextension/PhabricatorAuthMFAEditEngineExtension.php

Allow "Sign with MFA" to be applied as a comment action without requiring "CAN_EDIT"ClosedPublicActions