Page MenuHomePhabricator
Differential D20549

Remove the "search_documentfield" table
ClosedPublic
Actions

Authored by epriestley on May 23 2019, 4:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 7:49 AM
Unknown Object (File)
Sun, Feb 9, 7:49 AM
Unknown Object (File)
Sun, Feb 9, 7:49 AM
Unknown Object (File)
Tue, Jan 28, 5:23 PM
Unknown Object (File)
Sat, Jan 25, 5:09 AM
Unknown Object (File)
Sat, Jan 25, 5:09 AM
Unknown Object (File)
Sat, Jan 25, 5:09 AM
Unknown Object (File)
Tue, Jan 21, 12:03 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
amckinley
Maniphest Tasks
T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud)
Commits
rP719dd6d3f442: Remove the "search_documentfield" table
Summary

Ref T11741. See PHI1276. After the switch to "Ferret", this table has no remaining readers or writers.

Test Plan
  • Ran bin/storage upgrade -f, no warnings.
  • Grepped for class name, table name, stemmedCorpus column; got no relevant hits.
  • Did a fulltext search.

Diff Detail

Repository
rP Phabricator
Branch
myisam1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22898
Build 31410: Run Core Tests
Build 31409: arc lint + arc unit

Event Timeline

epriestley created this revision.May 23 2019, 4:55 PM
Owners added a subscriber: Restricted Owners Package.May 23 2019, 4:55 PM
Harbormaster completed remote builds in B22898: Diff 49023.May 23 2019, 4:56 PM
epriestley requested review of this revision.May 23 2019, 4:56 PM
epriestley added a child revision: D20550: Remove misleading reference to "search_documentfield" in documentation.May 23 2019, 5:00 PM
amckinley accepted this revision.May 23 2019, 5:18 PM
This revision is now accepted and ready to land.May 23 2019, 5:18 PM
amckinley added a comment.May 23 2019, 5:25 PM

If we're trying to drop the MyISAM dependency, don't forget to update the quickstart when we're finished: https://secure.phabricator.com/source/phabricator/browse/master/resources/sql/quickstart.sql$9727

epriestley added a comment.May 23 2019, 5:26 PM

Yeah, the end goal is to get those two MyISAM lines out of quickstart.sql. This gets one of 'em but is probably less than half the work. 🙈

Closed by commit rP719dd6d3f442: Remove the "search_documentfield" table (authored by epriestley). · Explain WhyMay 24 2019, 2:11 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in rP719dd6d3f442: Remove the "search_documentfield" table.
epriestley added a commit: rP719dd6d3f442: Remove the "search_documentfield" table.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
35 lines
1 line
src/
applications/
search/
storage/
document/

Diff 49023

View Options

resources/sql/autopatches/20161130.search.02.rebuild.php

Loading...
View Options

resources/sql/autopatches/20190523.myisam.01.documentfield.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/search/storage/document/PhabricatorSearchDocumentField.php

Loading...
Phabricator · Built by Phacility