Page MenuHomePhabricator

Add a "Published document changed" rule to Herald for Phriction documents
ClosedPublic

Authored by epriestley on May 13 2019, 5:30 PM.
Tags
None
Referenced Files
F13203240: D20520.diff
Tue, May 14, 11:35 PM
F13185534: D20520.diff
Sat, May 11, 2:59 AM
Unknown Object (File)
Tue, May 7, 5:27 AM
Unknown Object (File)
Fri, May 3, 2:53 AM
Unknown Object (File)
Thu, May 2, 6:35 AM
Unknown Object (File)
Mon, Apr 29, 2:33 PM
Unknown Object (File)
Sat, Apr 27, 12:53 AM
Unknown Object (File)
Fri, Apr 26, 2:18 PM
Subscribers
None

Details

Summary

Depends on D20519. Ref T13283. See PHI1202. Add a new rule which triggers when the current/most-recent transaction group includes a "content" or "publish" transaction, which means the published document content has changed.

Test Plan
  • Wrote a Herald rule using this field.
  • Created a document (rule matched).
  • Edited a document (rule matched).
  • Edited a document, saving as a draft (no match).
  • Edited a draft, updating it (no match).
  • Published a draft docuemnt (rule matched).

Diff Detail

Repository
rP Phabricator
Branch
herald3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22786
Build 31259: Run Core Tests
Build 31258: arc lint + arc unit