Page MenuHomePhabricator

Add a "Published document changed" rule to Herald for Phriction documents
ClosedPublic

Authored by epriestley on May 13 2019, 5:30 PM.
Tags
None
Referenced Files
F15476204: D20520.diff
Mon, Apr 7, 4:40 AM
F15473563: D20520.id48934.diff
Sat, Apr 5, 11:51 PM
F15466082: D20520.id48934.diff
Thu, Apr 3, 1:22 AM
F15462358: D20520.id48913.diff
Tue, Apr 1, 2:24 PM
F15437779: D20520.id.diff
Tue, Mar 25, 9:24 PM
F15435846: D20520.id.diff
Tue, Mar 25, 10:31 AM
F15429066: D20520.diff
Mon, Mar 24, 12:19 AM
F15424508: D20520.id.diff
Sat, Mar 22, 10:46 PM
Subscribers
None

Details

Summary

Depends on D20519. Ref T13283. See PHI1202. Add a new rule which triggers when the current/most-recent transaction group includes a "content" or "publish" transaction, which means the published document content has changed.

Test Plan
  • Wrote a Herald rule using this field.
  • Created a document (rule matched).
  • Edited a document (rule matched).
  • Edited a document, saving as a draft (no match).
  • Edited a draft, updating it (no match).
  • Published a draft docuemnt (rule matched).

Diff Detail

Repository
rP Phabricator
Branch
herald3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22786
Build 31259: Run Core Tests
Build 31258: arc lint + arc unit