Differential D20490

Fix the direction of the commit/revision edge
ClosedPublic
Actions

Authored by epriestley on May 1 2019, 3:47 PM.

Tags

None

Referenced Files

	F15416225: D20490.id48873.diff
	Thu, Mar 20, 9:56 AM

	F15386626: D20490.id.diff
	Sat, Mar 15, 12:58 AM

	Unknown Object (File)
	Mon, Mar 3, 6:42 AM

	Unknown Object (File)
	Mon, Mar 3, 6:41 AM

	Unknown Object (File)
	Mon, Mar 3, 6:41 AM

	Unknown Object (File)
	Mon, Mar 3, 6:41 AM

	Unknown Object (File)
	Feb 9 2025, 7:44 AM

	Unknown Object (File)
	Feb 9 2025, 7:44 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time

Summary

Ref T13276. This edge is pointed the wrong way. Point it the right way.

Test Plan

Will verify production works better.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 1 2019, 3:47 PM

Harbormaster completed remote builds in B22746: Diff 48873.May 1 2019, 3:49 PM

epriestley requested review of this revision.May 1 2019, 3:49 PM

amckinley accepted this revision.May 2 2019, 12:50 PM

This revision is now accepted and ready to land.May 2 2019, 12:50 PM

Closed by commit rP5dc4e76eb9f8: Fix the direction of the commit/revision edge (authored by epriestley). · Explain WhyMay 2 2019, 2:28 PM

This revision was automatically updated to reflect the committed changes.

epriestley added an edge: rP5dc4e76eb9f8: Fix the direction of the commit/revision edge.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

worker/

DiffusionUpdateObjectAfterCommitWorker.php

2 lines

Diff 48882

View Options

src/applications/diffusion/worker/DiffusionUpdateObjectAfterCommitWorker.php

Fix the direction of the commit/revision edgeClosedPublicActions