In ApplicationTransactionEditor, determine new objects with "getID()" instead of "getPHID()"
ClosedPublicDraft
Actions

Authored by epriestley on Apr 29 2019, 2:36 PM.

Details

Reviewers

amckinley

Summary

See https://discourse.phabricator-community.org/t/unable-to-reload-object-that-hasnt-been-loaded/2677.

When editing "Config" objects, they currently get a PHID set outside of the TransactionEditor. They probably should not, but fixing that is likely an involved change.

This causes us to incorrectly fail to detect $is_new correctly and try to reload() and object with no ID.

To work around this, test for new objects with getID() instead of getPHID().

Test Plan

Edited any config value with the web UI.

Diff Detail

Repository

rP Phabricator

Branch

id1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22730
Build 31162: Run Core Tests
Build 31161: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 29 2019, 2:36 PM

This revision was not accepted when it landed; it landed in state Draft.Apr 29 2019, 2:37 PM

This revision was landed with ongoing or failed builds.

Closed by commit rP0d9362355b1e: In ApplicationTransactionEditor, determine new objects with "getID()" instead… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added an edge: rP0d9362355b1e: In ApplicationTransactionEditor, determine new objects with "getID()" instead….

(This is a consequence of D20462, which was actually performing a separate getID() test, I just merged the getID() test into the $is_new test in that change.)

Harbormaster completed remote builds in B22730: Diff 48857.Apr 29 2019, 2:39 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

2 lines

Diff 48857

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

In ApplicationTransactionEditor, determine new objects with "getID()" instead of "getPHID()"ClosedPublicDraftActions