Page MenuHomePhabricator

Improve the performance of tab replacement in common cases
ClosedPublic

Authored by epriestley on Apr 25 2019, 9:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 5:19 AM
Unknown Object (File)
Tue, Jan 28, 3:47 PM
Unknown Object (File)
Mon, Jan 27, 6:53 AM
Unknown Object (File)
Sat, Jan 25, 4:56 AM
Unknown Object (File)
Sat, Jan 25, 4:56 AM
Unknown Object (File)
Sat, Jan 25, 4:56 AM
Unknown Object (File)
Sat, Jan 25, 4:56 AM
Unknown Object (File)
Jan 3 2025, 2:14 AM
Subscribers
None

Details

Summary

See PHI1210. For certain large inputs, we spend more time than we need to replacing tabs with spaces. Add some fast paths:

  • When a line only has tabs at the beginning of the line, we don't need to do as much work parsing the rest of the line.
  • When a line has no unicode characters, we don't need to vectorize it to get the right result.
Test Plan
  • Added test coverage.
  • Profiled this, got a ~60x performance increase on a 36,000 line 3MB text file.

Diff Detail

Repository
rP Phabricator
Branch
tabs1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/parser/DifferentialChangesetParser.php:1459XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 22724
Build 31150: Run Core Tests
Build 31149: arc lint + arc unit