Page MenuHomePhabricator

Improve the performance of tab replacement in common cases
ClosedPublic

Authored by epriestley on Apr 25 2019, 9:38 PM.
Tags
None
Referenced Files
F13045635: D20477.diff
Thu, Apr 18, 1:30 AM
Unknown Object (File)
Sun, Mar 31, 4:53 AM
Unknown Object (File)
Mar 19 2024, 3:27 PM
Unknown Object (File)
Mar 19 2024, 3:27 PM
Unknown Object (File)
Mar 19 2024, 3:27 PM
Unknown Object (File)
Mar 19 2024, 3:27 PM
Unknown Object (File)
Dec 27 2023, 1:52 AM
Unknown Object (File)
Dec 24 2023, 4:07 AM
Subscribers
None

Details

Summary

See PHI1210. For certain large inputs, we spend more time than we need to replacing tabs with spaces. Add some fast paths:

  • When a line only has tabs at the beginning of the line, we don't need to do as much work parsing the rest of the line.
  • When a line has no unicode characters, we don't need to vectorize it to get the right result.
Test Plan
  • Added test coverage.
  • Profiled this, got a ~60x performance increase on a 36,000 line 3MB text file.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable