Page MenuHomePhabricator

Generalize Legalpad validation logic for "Require Signature"
ClosedPublic

Authored by epriestley on Mar 22 2019, 4:27 PM.
Tags
None
Referenced Files
F21991777: D20311.diff
Mon, Aug 17, 4:39 PM
Unknown Object (File)
Mar 3 2026, 1:19 AM
Unknown Object (File)
Dec 2 2025, 12:28 PM
Unknown Object (File)
Nov 17 2025, 12:52 PM
Unknown Object (File)
Oct 28 2025, 6:16 PM
Unknown Object (File)
Oct 10 2025, 6:27 PM
Unknown Object (File)
Oct 9 2025, 8:56 AM
Unknown Object (File)
Oct 5 2025, 8:35 AM
Subscribers
None

Details

Summary

See downstream https://phabricator.wikimedia.org/T208254.

I can't actually reproduce any issue here (we only show this field when creating a document, and only if the viewer is an administrator), so maybe this relied on some changes or was originally reported against older code.

Regardless, the validation isn't quite right: it requires administrator privileges to apply this transaction at all, but should only require administrator privileges to change the value.

Test Plan

Edited Legalpad documents as an administrator and non-administrator before and after the change, with and without signatures being required.

Couldn't reproduce the original issue, but this version is generally more correct/robust.

Diff Detail

Repository
rP Phabricator
Branch
legalpad1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22329
Build 30550: Run Core Tests
Build 30549: arc lint + arc unit