Improve utilization of "AuthTemporaryToken" table keys in LFS authentication queries
ClosedPublic
Actions

Authored by epriestley on Mar 7 2019, 4:34 PM.

Details

Reviewers

amckinley

Commits

rP9913754a2aa2: Improve utilization of "AuthTemporaryToken" table keys in LFS authentication…

Summary

See PHI1123. The key on this table is <resource, type, code> but we currently query for only <type, code>. This can't use the key.

Constrain the query to the resource we expect (the repository) so it can use the key.

Test Plan

Pushed files using LFS. See PHI1123 for more, likely.

Diff Detail

Repository

rP Phabricator

Branch

authkey1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22227
Build 30390: Run Core Tests
Build 30389: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 7 2019, 4:34 PM

Harbormaster completed remote builds in B22214: Diff 48355.Mar 7 2019, 4:36 PM

epriestley requested review of this revision.Mar 7 2019, 4:36 PM

epriestley mentioned this in D20262: Reuse recently issued Git LFS authentication tokens.Mar 7 2019, 5:24 PM

amckinley accepted this revision.Mar 7 2019, 9:52 PM

amckinley added inline comments.

src/applications/diffusion/controller/DiffusionServeController.php
677	"resource"

This revision is now accepted and ready to land.Mar 7 2019, 9:52 PM

Typo fix.

Harbormaster completed remote builds in B22227: Diff 48368.Mar 7 2019, 9:55 PM

Closed by commit rP9913754a2aa2: Improve utilization of "AuthTemporaryToken" table keys in LFS authentication… (authored by epriestley). · Explain WhyMar 7 2019, 10:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionServeController.php

32 lines

Diff 48368

View Options

src/applications/diffusion/controller/DiffusionServeController.php

Improve utilization of "AuthTemporaryToken" table keys in LFS authentication queriesClosedPublicActions