Page MenuHomePhabricator

Reuse recently issued Git LFS authentication tokens
Changes PlannedPublic

Authored by epriestley on Mar 7 2019, 5:24 PM.
Tags
None
Referenced Files
F15495101: D20262.id48356.diff
Sun, Apr 13, 2:43 AM
F15489031: D20262.id.diff
Fri, Apr 11, 5:25 AM
F15485872: D20262.diff
Thu, Apr 10, 3:12 AM
F15480994: D20262.id48356.diff
Tue, Apr 8, 5:42 PM
F15477587: D20262.id48356.diff
Mon, Apr 7, 4:21 PM
F15477586: D20262.id48356.diff
Mon, Apr 7, 4:21 PM
F15463925: D20262.diff
Wed, Apr 2, 4:34 AM
F15426297: D20262.diff
Sun, Mar 23, 7:57 AM
Subscribers
None

Details

Reviewers
amckinley
Summary

See PHI1123. Currently, we generate a new Git LFS authentication token for each LFS request. This is simple, and it allows the tokens to be ephemeral.

We can reuse tokens to make the table smaller, at the cost of simplicity and ephemerality. Not clear this is really necessary when combined with D20261.

Test Plan

Not totally sure about this yet.

Diff Detail

Repository
rP Phabricator
Branch
authkey2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22215
Build 30375: Run Core Tests
Build 30374: arc lint + arc unit