Differential D20237

Recognize the official "Go" magic regexp for generated code as generated
ClosedPublic
Actions

Authored by epriestley on Mar 1 2019, 2:58 PM.

Details

Reviewers

Commits

rPcc8dda629905: Recognize the official "Go" magic regexp for generated code as generated

Summary

See PHI1112. See T784. Although some more general/flexible solution is arriving eventually, adding this rule seems reasonable for now, since it's not a big deal if we remove it later to replace this with some fancier system.

Test Plan

Created a diff with the official Go generated marker, saw the changeset marked as generated.

Diff Detail

Repository

rP Phabricator

Branch

generated1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22165
Build 30293: Run Core Tests
Build 30292: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 1 2019, 2:58 PM

Harbormaster completed remote builds in B22165: Diff 48304.Mar 1 2019, 3:00 PM

epriestley requested review of this revision.Mar 1 2019, 3:00 PM

amckinley accepted this revision.Mar 5 2019, 6:16 PM

This revision is now accepted and ready to land.Mar 5 2019, 6:16 PM

Closed by commit rPcc8dda629905: Recognize the official "Go" magic regexp for generated code as generated (authored by epriestley). · Explain WhyMar 5 2019, 7:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

engine/

DifferentialChangesetEngine.php

6 lines

Diff 48304

View Options

src/applications/differential/engine/DifferentialChangesetEngine.php

Recognize the official "Go" magic regexp for generated code as generatedClosedPublicActions