Page MenuHomePhabricator
Differential D20237

Recognize the official "Go" magic regexp for generated code as generated
ClosedPublic
Actions

Authored by epriestley on Mar 1 2019, 2:58 PM.
Tags
None
Referenced Files
F15431478: D20237.id.diff
Mon, Mar 24, 12:33 PM
F15428485: D20237.diff
Sun, Mar 23, 8:40 PM
F15424991: D20237.id48304.diff
Sun, Mar 23, 1:37 AM
F15420486: D20237.id48325.diff
Fri, Mar 21, 2:22 PM
F15417794: D20237.diff
Thu, Mar 20, 6:38 PM
F15413292: D20237.id.diff
Wed, Mar 19, 5:52 PM
F15403614: D20237.diff
Tue, Mar 18, 4:08 AM
Unknown Object (File)
Thu, Feb 27, 3:59 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPcc8dda629905: Recognize the official "Go" magic regexp for generated code as generated
Summary

See PHI1112. See T784. Although some more general/flexible solution is arriving eventually, adding this rule seems reasonable for now, since it's not a big deal if we remove it later to replace this with some fancier system.

Test Plan

Created a diff with the official Go generated marker, saw the changeset marked as generated.

Diff Detail

Repository
rP Phabricator
Branch
generated1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22165
Build 30293: Run Core Tests
Build 30292: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
engine/
6 lines

Diff 48304

View Options

src/applications/differential/engine/DifferentialChangesetEngine.php

Loading...
Phabricator · Built by Phacility