Page MenuHomePhabricator
Differential D20237

Recognize the official "Go" magic regexp for generated code as generated
ClosedPublic
Actions

Authored by epriestley on Mar 1 2019, 2:58 PM.
Tags
None
Referenced Files
F14796495: D20237.id48325.diff
Sat, Jan 25, 4:01 AM
F14796494: D20237.id48304.diff
Sat, Jan 25, 4:01 AM
F14796493: D20237.id.diff
Sat, Jan 25, 4:01 AM
Unknown Object (File)
Tue, Jan 21, 12:49 PM
Unknown Object (File)
Thu, Jan 2, 7:27 PM
Unknown Object (File)
Fri, Dec 27, 7:51 PM
Unknown Object (File)
Fri, Dec 27, 4:50 PM
Unknown Object (File)
Dec 26 2024, 8:50 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPcc8dda629905: Recognize the official "Go" magic regexp for generated code as generated
Summary

See PHI1112. See T784. Although some more general/flexible solution is arriving eventually, adding this rule seems reasonable for now, since it's not a big deal if we remove it later to replace this with some fancier system.

Test Plan

Created a diff with the official Go generated marker, saw the changeset marked as generated.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
engine/
6 lines

Diff 48325

View Options

src/applications/differential/engine/DifferentialChangesetEngine.php

Loading...
Phabricator · Built by Phacility