Page MenuHomePhabricator

Don't require any special capabilities to apply a "closed a subtask" transaction to a parent task
ClosedPublic

Authored by epriestley on Feb 28 2019, 4:09 PM.
Tags
None
Referenced Files
F13147173: D20223.id.diff
Fri, May 3, 12:43 PM
F13135137: D20223.id.diff
Thu, May 2, 7:10 AM
Unknown Object (File)
Tue, Apr 30, 11:18 PM
Unknown Object (File)
Sat, Apr 27, 11:10 AM
Unknown Object (File)
Wed, Apr 24, 6:51 PM
Unknown Object (File)
Mon, Apr 22, 10:34 PM
Unknown Object (File)
Sat, Apr 20, 4:38 PM
Unknown Object (File)
Thu, Apr 11, 7:06 AM
Subscribers
None

Details

Summary

See PHI1059. If you close a task, we apply an "alice closed a subtask: X" transaction to its parents.

This transaction is purely informative, but currently requires CAN_EDIT permission after T13186. However, we'd prefer to post this transaction anyway, even if: the parent is locked; or the parent is not editable by the acting user.

Replace the implicit CAN_EDIT requirement with no requirement.

(This transaction is only applied internally (by closing a subtask) and can't be applied via the API or any other channel, so this doesn't let attackers spam a bunch of bogus subtask closures all over the place or anything.)

Test Plan
  • Created a parent task A with subtask B.
  • Put task A into an "Edits Locked" status.
  • As a user other than the owner of A, closed B.

Then:

  • Before: Policy exception when trying to apply the "alice closed a subtask: B" transaction to A.
  • After: B closed, A got a transaction despite being locked.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable