Page MenuHomePhabricator

Implement Build Plan behavior "Affects Buildable"
ClosedPublic

Authored by epriestley on Feb 28 2019, 9:24 PM.
Tags
None
Referenced Files
F14803795: D20233.diff
Sat, Jan 25, 4:16 PM
F14796476: D20233.id48339.diff
Sat, Jan 25, 4:00 AM
F14796475: D20233.id48293.diff
Sat, Jan 25, 3:59 AM
F14796473: D20233.id.diff
Sat, Jan 25, 3:59 AM
F14796472: D20233.diff
Sat, Jan 25, 3:59 AM
Unknown Object (File)
Fri, Jan 24, 7:09 AM
Unknown Object (File)
Tue, Jan 21, 10:26 AM
Unknown Object (File)
Sun, Jan 12, 1:49 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13258. Make the "Affects Buildable" option actually work.

Test Plan
  • As in previous change, created a "wait for HTTP request" build plan and had it always run against every revision.
  • Created revisions, waited a bit, then sent the build a "Fail" message, with different values of "Affects Buildable":
  • "Always": Same behavior as today. Buildable waited for the build, then failed when it failed.
  • "While Building": Buildable waited for the build, but passed even though it failed (buildable has green checkmark even though build is red):

Screen Shot 2019-02-28 at 1.21.29 PM.png (78×316 px, 10 KB)

  • "Never": Buildable passed immediately (buildable has green checkmark even though build is still running):

Screen Shot 2019-02-28 at 1.21.49 PM.png (72×323 px, 10 KB)

Diff Detail

Repository
rP Phabricator
Branch
harbor10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22155
Build 30279: Run Core Tests
Build 30278: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 28 2019, 9:24 PM
This revision is now accepted and ready to land.Mar 5 2019, 7:52 PM
This revision was automatically updated to reflect the committed changes.