Page MenuHomePhabricator
Differential D20210

Make the Diffusion warning about "svnlook" and PATH more clear
ClosedPublic
Actions

Authored by epriestley on Feb 25 2019, 2:20 PM.
Tags
None
Referenced Files
F13189563: D20210.diff
Sat, May 11, 6:11 AM
Unknown Object (File)
Tue, May 7, 9:49 AM
Unknown Object (File)
Mon, May 6, 12:34 PM
Unknown Object (File)
Sat, May 4, 4:29 PM
Unknown Object (File)
Fri, May 3, 9:37 AM
Unknown Object (File)
Thu, Apr 25, 2:17 PM
Unknown Object (File)
Thu, Apr 25, 3:17 AM
Unknown Object (File)
Apr 11 2024, 10:40 AM
View All 97 Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPf61e825905c1: Make the Diffusion warning about "svnlook" and PATH more clear
Summary

See https://discourse.phabricator-community.org/t/display-error-on-the-status-page-for-svn-repos/2443 for discussion.

The UI currently shows a misleading warning that looks like "found svnlook; can't find svnlook".

It actually means "found svnlook, but when Subversion wipes PATH before executing commit hooks, we will no longer be able to find it".

Test Plan

Screen Shot 2019-02-25 at 6.16.46 AM.png (60×952 px, 27 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
management/
16 lines

Diff 48255

View Options

src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php

Loading...
Phabricator · Built by Phacility