Page MenuHomePhabricator

Make the Diffusion warning about "svnlook" and PATH more clear
ClosedPublic

Authored by epriestley on Feb 25 2019, 2:20 PM.
Tags
None
Referenced Files
F12839357: D20210.id48252.diff
Thu, Mar 28, 7:22 PM
F12827359: D20210.id48255.diff
Thu, Mar 28, 9:59 AM
Unknown Object (File)
Sun, Mar 10, 3:12 PM
Unknown Object (File)
Feb 10 2024, 5:17 AM
Unknown Object (File)
Feb 9 2024, 7:25 PM
Unknown Object (File)
Dec 26 2023, 5:55 PM
Unknown Object (File)
Dec 22 2023, 8:13 PM
Unknown Object (File)
Dec 21 2023, 2:09 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/display-error-on-the-status-page-for-svn-repos/2443 for discussion.

The UI currently shows a misleading warning that looks like "found svnlook; can't find svnlook".

It actually means "found svnlook, but when Subversion wipes PATH before executing commit hooks, we will no longer be able to find it".

Test Plan

Screen Shot 2019-02-25 at 6.16.46 AM.png (60×952 px, 27 KB)

Diff Detail

Repository
rP Phabricator
Branch
svnlook1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22113
Build 30210: Run Core Tests
Build 30209: arc lint + arc unit