Differential D20210

Make the Diffusion warning about "svnlook" and PATH more clear
ClosedPublic
Actions

Authored by epriestley on Feb 25 2019, 2:20 PM.

Details

Reviewers

amckinley

Commits

rPf61e825905c1: Make the Diffusion warning about "svnlook" and PATH more clear

Summary

See https://discourse.phabricator-community.org/t/display-error-on-the-status-page-for-svn-repos/2443 for discussion.

The UI currently shows a misleading warning that looks like "found svnlook; can't find svnlook".

It actually means "found svnlook, but when Subversion wipes PATH before executing commit hooks, we will no longer be able to find it".

Test Plan

Diff Detail

Repository

rP Phabricator

Branch

svnlook1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22113
Build 30210: Run Core Tests
Build 30209: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 25 2019, 2:20 PM

Harbormaster completed remote builds in B22113: Diff 48252.Feb 25 2019, 2:22 PM

epriestley requested review of this revision.Feb 25 2019, 2:22 PM

amckinley accepted this revision.Feb 25 2019, 3:08 PM

This revision is now accepted and ready to land.Feb 25 2019, 3:08 PM

Closed by commit rPf61e825905c1: Make the Diffusion warning about "svnlook" and PATH more clear (authored by epriestley). · Explain WhyFeb 25 2019, 6:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

management/

DiffusionRepositoryBasicsManagementPanel.php

16 lines

Diff 48252

View Options

src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php

Make the Diffusion warning about "svnlook" and PATH more clearClosedPublicActions