Page MenuHomePhabricator
Differential D20210

Make the Diffusion warning about "svnlook" and PATH more clear
ClosedPublic
Actions

Authored by epriestley on Feb 25 2019, 2:20 PM.
Tags
None
Referenced Files
F15518743: D20210.diff
Sat, Apr 19, 4:29 PM
F15491755: D20210.id48252.diff
Sat, Apr 12, 7:07 AM
F15490878: D20210.id48255.diff
Fri, Apr 11, 9:18 PM
F15490280: D20210.id48252.diff
Fri, Apr 11, 3:56 PM
F15489466: D20210.id48255.diff
Fri, Apr 11, 9:19 AM
F15489166: D20210.id.diff
Fri, Apr 11, 6:32 AM
F15486443: D20210.diff
Thu, Apr 10, 7:10 AM
F15439981: D20210.id48255.diff
Wed, Mar 26, 10:37 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPf61e825905c1: Make the Diffusion warning about "svnlook" and PATH more clear
Summary

See https://discourse.phabricator-community.org/t/display-error-on-the-status-page-for-svn-repos/2443 for discussion.

The UI currently shows a misleading warning that looks like "found svnlook; can't find svnlook".

It actually means "found svnlook, but when Subversion wipes PATH before executing commit hooks, we will no longer be able to find it".

Test Plan

Screen Shot 2019-02-25 at 6.16.46 AM.png (60×952 px, 27 KB)

Diff Detail

Repository
rP Phabricator
Branch
svnlook1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22113
Build 30210: Run Core Tests
Build 30209: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
management/
16 lines

Diff 48252

View Options

src/applications/diffusion/management/DiffusionRepositoryBasicsManagementPanel.php

Loading...
Phabricator · Built by Phacility