Page MenuHomePhabricator
Differential D20202

Add "random_int" and "random_bytes" as builtins so the linter stops complaining about them
ClosedPublic
Actions

Authored by epriestley on Feb 20 2019, 10:59 PM.
Tags
None
Referenced Files
F15493980: D20202.id48237.diff
Sat, Apr 12, 10:18 PM
F15493034: D20202.id48236.diff
Sat, Apr 12, 8:57 PM
F15489874: D20202.id.diff
Fri, Apr 11, 1:02 PM
F15488129: D20202.diff
Thu, Apr 10, 7:45 PM
F15484648: D20202.id48236.diff
Wed, Apr 9, 7:22 PM
F15476168: D20202.id48237.diff
Mon, Apr 7, 4:34 AM
F15474906: D20202.diff
Sun, Apr 6, 1:29 PM
F15472876: D20202.diff
Sat, Apr 5, 5:07 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPHU671ec8fb8f7a: Add "random_int" and "random_bytes" as builtins so the linter stops complaining…
Summary

There's a "right" way to do this by regenerating this file from PHPCompatInfo, but that requires installing composer and a whole lot of legwork. For now, I think we only actually care about these two functions, so I just added them manually.

Test Plan

On PHP7, ran arc lint on Filesystem.php and got no warnings. This change should also stop us from getting warnings on earlier versions of PHP.

Diff Detail

Repository
rPHU libphutil
Branch
builtins1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22093
Build 30180: Run Core Tests
Build 30179: arc lint + arc unit

Revision Contents
Changeset List

PathSize
resources/

Diff 48236

View Options

resources/php_compat_info.json

Loading...
Phabricator · Built by Phacility