Add "random_int" and "random_bytes" as builtins so the linter stops complaining about them
ClosedPublic
Actions

Authored by epriestley on Feb 20 2019, 10:59 PM.

Details

Reviewers

amckinley

Commits

rPHU671ec8fb8f7a: Add "random_int" and "random_bytes" as builtins so the linter stops complaining…

Summary

There's a "right" way to do this by regenerating this file from PHPCompatInfo, but that requires installing composer and a whole lot of legwork. For now, I think we only actually care about these two functions, so I just added them manually.

Test Plan

On PHP7, ran arc lint on Filesystem.php and got no warnings. This change should also stop us from getting warnings on earlier versions of PHP.

Diff Detail

Repository

rPHU libphutil

Branch

builtins1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22093
Build 30180: Run Core Tests
Build 30179: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 20 2019, 10:59 PM

Harbormaster completed remote builds in B22093: Diff 48236.Feb 20 2019, 10:59 PM

epriestley requested review of this revision.Feb 20 2019, 10:59 PM

amckinley accepted this revision.Feb 20 2019, 11:00 PM

This revision is now accepted and ready to land.Feb 20 2019, 11:00 PM

Closed by commit rPHU671ec8fb8f7a: Add "random_int" and "random_bytes" as builtins so the linter stops complaining… (authored by epriestley). · Explain WhyFeb 20 2019, 11:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

php_compat_info.json

Diff 48236

View Options

resources/php_compat_info.json

Add "random_int" and "random_bytes" as builtins so the linter stops complaining about themClosedPublicActions