Differential D20201

Add milliseconds and microseconds to phutil_units
ClosedPublic
Actions

Authored by amckinley on Feb 20 2019, 10:37 PM.

Tags

None

Referenced Files

	F21692988: D20201.id48233.diff
	Fri, Aug 7, 12:10 PM

	F21690505: D20201.diff
	Fri, Aug 7, 8:59 AM

	Unknown Object (File)
	Jul 1 2026, 7:52 PM

	Unknown Object (File)
	Jun 30 2026, 2:18 AM

	Unknown Object (File)
	Jun 27 2026, 7:54 PM

	Unknown Object (File)
	Jun 23 2026, 2:40 AM

	Unknown Object (File)
	Dec 2 2025, 12:27 PM

	Unknown Object (File)
	Nov 28 2025, 7:06 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rPHUc6bd8315c188: Add milliseconds and microseconds to phutil_units

Summary

Used in D20200. Counting is zeroes is hard.

Test Plan

Updated unit tests; used Google to confirm test values.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

amckinley created this revision.Feb 20 2019, 10:37 PM

amckinley added a child revision: D20200: Track total time from task creation to task archival.Feb 20 2019, 10:37 PM

Harbormaster completed remote builds in B22090: Diff 48233.Feb 20 2019, 10:37 PM

amckinley requested review of this revision.Feb 20 2019, 10:37 PM

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 20 2019, 10:37 PM

epriestley accepted this revision.Feb 20 2019, 10:38 PM

This revision is now accepted and ready to land.Feb 20 2019, 10:38 PM

Closed by commit rPHUc6bd8315c188: Add milliseconds and microseconds to phutil_units (authored by amckinley). · Explain WhyFeb 20 2019, 10:40 PM

This revision was automatically updated to reflect the committed changes.

amckinley mentioned this in D20200: Track total time from task creation to task archival.Feb 20 2019, 10:42 PM

Revision Contents
Changeset List

Path

Size

src/

utils/

__tests__/

PhutilUtilsTestCase.php

3 lines

utils.php

54 lines

Diff 48234

View Options

src/utils/tests/PhutilUtilsTestCase.php

View Options

Add milliseconds and microseconds to phutil_unitsClosedPublicActions