Page MenuHomePhabricator

Tweak some display behaviors for indent indicators
ClosedPublic

Authored by epriestley on Feb 19 2019, 11:00 PM.
Tags
None
Referenced Files
F21973795: D20195.diff
Mon, Aug 17, 5:11 AM
Unknown Object (File)
Jun 26 2026, 2:05 AM
Unknown Object (File)
Jun 22 2026, 8:49 PM
Unknown Object (File)
Jun 22 2026, 1:58 PM
Unknown Object (File)
Jun 21 2026, 6:00 AM
Unknown Object (File)
Jun 8 2026, 4:50 PM
Unknown Object (File)
Apr 7 2026, 7:47 PM
Unknown Object (File)
Apr 7 2026, 6:04 PM
Subscribers
None

Details

Summary

Ref T13161.

  • Don't show ">>" when the line indentation changed but the text also changed, this is just "the line changed".
  • The indicator seems a little cleaner if we just reuse the existing "bright" colors, which already have colorblind colors anyway.
Test Plan

Got slightly better rendering for some diffs locally.

Diff Detail

Repository
rP Phabricator
Branch
diff1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22071
Build 30150: Run Core Tests
Build 30149: arc lint + arc unit