Page MenuHomePhabricator

Tweak some display behaviors for indent indicators
ClosedPublic

Authored by epriestley on Feb 19 2019, 11:00 PM.
Tags
None
Referenced Files
F15455638: D20195.id.diff
Sun, Mar 30, 3:56 AM
F15422105: D20195.id48215.diff
Sat, Mar 22, 5:33 AM
F15420890: D20195.id.diff
Fri, Mar 21, 6:41 PM
F15418002: D20195.id48215.diff
Thu, Mar 20, 8:04 PM
F15417103: D20195.diff
Thu, Mar 20, 3:20 PM
F15409027: D20195.diff
Wed, Mar 19, 2:51 AM
Unknown Object (File)
Feb 17 2025, 8:51 AM
Unknown Object (File)
Feb 10 2025, 9:38 AM
Subscribers
None

Details

Summary

Ref T13161.

  • Don't show ">>" when the line indentation changed but the text also changed, this is just "the line changed".
  • The indicator seems a little cleaner if we just reuse the existing "bright" colors, which already have colorblind colors anyway.
Test Plan

Got slightly better rendering for some diffs locally.

Diff Detail

Repository
rP Phabricator
Branch
diff1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22071
Build 30150: Run Core Tests
Build 30149: arc lint + arc unit