Page MenuHomePhabricator

Tweak some display behaviors for indent indicators
ClosedPublic

Authored by epriestley on Feb 19 2019, 11:00 PM.
Tags
None
Referenced Files
F19926736: D20195.diff
Tue, Apr 7, 6:04 PM
F19922981: D20195.id48222.diff
Mon, Apr 6, 11:55 PM
F19922712: D20195.id48215.diff
Mon, Apr 6, 8:42 PM
F19898539: D20195.diff
Sun, Mar 29, 1:39 PM
F19600109: D20195.id48215.diff
Feb 3 2026, 3:07 AM
F19600106: D20195.id48215.diff
Feb 3 2026, 3:07 AM
F19555442: D20195.diff
Jan 30 2026, 3:20 PM
F19507524: D20195.id48215.diff
Jan 9 2026, 9:13 PM
Subscribers
None

Details

Summary

Ref T13161.

  • Don't show ">>" when the line indentation changed but the text also changed, this is just "the line changed".
  • The indicator seems a little cleaner if we just reuse the existing "bright" colors, which already have colorblind colors anyway.
Test Plan

Got slightly better rendering for some diffs locally.

Diff Detail

Repository
rP Phabricator
Branch
diff1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22071
Build 30150: Run Core Tests
Build 30149: arc lint + arc unit