Page MenuHomePhabricator

Tweak some display behaviors for indent indicators
ClosedPublic

Authored by epriestley on Feb 19 2019, 11:00 PM.

Details

Summary

Ref T13161.

  • Don't show ">>" when the line indentation changed but the text also changed, this is just "the line changed".
  • The indicator seems a little cleaner if we just reuse the existing "bright" colors, which already have colorblind colors anyway.
Test Plan

Got slightly better rendering for some diffs locally.

Diff Detail

Repository
rP Phabricator
Branch
diff1
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 22071
Build 30150: Run Core Tests
Build 30149: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 19 2019, 11:00 PM
epriestley requested review of this revision.Feb 19 2019, 11:02 PM
amckinley accepted this revision.Feb 19 2019, 11:33 PM
This revision is now accepted and ready to land.Feb 19 2019, 11:33 PM
This revision was automatically updated to reflect the committed changes.