Paths

Table of Contentst

Differential D20184

Clean up a couple more URI alter() calls
ClosedPublic
Actions

Authored by epriestley on Feb 15 2019, 9:58 PM.

Tags

None

Referenced Files

	F13281822: D20184.diff
	Sun, Jun 2, 11:16 AM

	F13248949: D20184.diff
	Fri, May 24, 5:39 AM

	F13243147: D20184.diff
	Thu, May 23, 3:24 AM

	F13239024: D20184.id48179.diff
	Tue, May 21, 11:30 PM

	F13236663: D20184.id48180.diff
	Tue, May 21, 10:24 AM

	F13221515: D20184.diff
	Sun, May 19, 2:50 AM

	F13203916: D20184.diff
	Wed, May 15, 12:13 AM

	F13186560: D20184.diff
	Sat, May 11, 3:42 AM

View All 88 Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPb09cf166a8bd: Clean up a couple more URI alter() calls

Summary

See https://discourse.phabricator-community.org/t/create-new-phriction-document-fails-with-unhandled-exception-invalidargumentexception/2406.

These weren't obviously nullable from a cursory grep, but are sometimes nullable in practice.

Test Plan

Created, then saved a new Phriction document.

Diff Detail

Repository

rP Phabricator

Branch

alter2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22024
Build 30090: Run Core Tests
Build 30089: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 15 2019, 9:58 PM

Harbormaster completed remote builds in B22024: Diff 48179.Feb 15 2019, 10:00 PM

epriestley requested review of this revision.Feb 15 2019, 10:00 PM

amckinley accepted this revision.Feb 15 2019, 10:01 PM

This revision is now accepted and ready to land.Feb 15 2019, 10:01 PM

Closed by commit rPb09cf166a8bd: Clean up a couple more URI alter() calls (authored by epriestley). · Explain WhyFeb 15 2019, 10:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

editor/

PhrictionTransactionEditor.php

11 lines

view/

phui/

PHUITimelineView.php

17 lines

Diff 48179

View Options

src/applications/phriction/editor/PhrictionTransactionEditor.php