Paths

Table of Contentst

Differential D20184

Clean up a couple more URI alter() calls
ClosedPublic
Actions

Authored by epriestley on Feb 15 2019, 9:58 PM.

Tags

None

Referenced Files

	F13128427: D20184.diff
	Tue, Apr 30, 11:55 PM

	Unknown Object (File)
	Thu, Apr 25, 12:43 AM

	Unknown Object (File)
	Mar 29 2024, 5:02 AM

	Unknown Object (File)
	Mar 29 2024, 12:51 AM

	Unknown Object (File)
	Mar 23 2024, 11:27 AM

	Unknown Object (File)
	Mar 15 2024, 10:56 AM

	Unknown Object (File)
	Feb 11 2024, 7:44 PM

	Unknown Object (File)
	Jan 15 2024, 3:17 PM

View All 78 Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPb09cf166a8bd: Clean up a couple more URI alter() calls

Summary

See https://discourse.phabricator-community.org/t/create-new-phriction-document-fails-with-unhandled-exception-invalidargumentexception/2406.

These weren't obviously nullable from a cursory grep, but are sometimes nullable in practice.

Test Plan

Created, then saved a new Phriction document.

Diff Detail

Repository

rP Phabricator

Branch

alter2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22024
Build 30090: Run Core Tests
Build 30089: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 15 2019, 9:58 PM

Harbormaster completed remote builds in B22024: Diff 48179.Feb 15 2019, 10:00 PM

epriestley requested review of this revision.Feb 15 2019, 10:00 PM

amckinley accepted this revision.Feb 15 2019, 10:01 PM

This revision is now accepted and ready to land.Feb 15 2019, 10:01 PM

Closed by commit rPb09cf166a8bd: Clean up a couple more URI alter() calls (authored by epriestley). · Explain WhyFeb 15 2019, 10:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

editor/

PhrictionTransactionEditor.php

11 lines

view/

phui/

PHUITimelineView.php

17 lines

Diff 48179

View Options

src/applications/phriction/editor/PhrictionTransactionEditor.php