Differential D20148

In Webhooks, label HTTP response codes as "HTTP Status Code", not "HTTP Error"
ClosedPublic
Actions

Authored by epriestley on Feb 12 2019, 1:52 PM.

Tags

None

Referenced Files

	F14412825: D20148.diff
	Tue, Dec 24, 1:29 PM

	Unknown Object (File)
	Fri, Dec 13, 9:32 AM

	Unknown Object (File)
	Mon, Dec 9, 5:22 PM

	Unknown Object (File)
	Fri, Dec 6, 9:49 AM

	Unknown Object (File)
	Tue, Dec 3, 8:24 PM

	Unknown Object (File)
	Fri, Nov 29, 11:37 AM

	Unknown Object (File)
	Nov 18 2024, 10:15 PM

	Unknown Object (File)
	Nov 15 2024, 10:41 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rP00ffb190cc71: In Webhooks, label HTTP response codes as "HTTP Status Code", not "HTTP Error"

Summary

See PHI1068. We currently show "HTTP Error - 200", which is misleading. Instead, label these results as "HTTP Status Code".

Test Plan

Diff Detail

Repository

rP Phabricator

Branch

hook1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21951
Build 29974: Run Core Tests
Build 29973: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 12 2019, 1:52 PM

Harbormaster completed remote builds in B21951: Diff 48108.Feb 12 2019, 1:54 PM

epriestley requested review of this revision.Feb 12 2019, 1:54 PM

amckinley accepted this revision.Feb 12 2019, 7:09 PM

This revision is now accepted and ready to land.Feb 12 2019, 7:09 PM

Closed by commit rP00ffb190cc71: In Webhooks, label HTTP response codes as "HTTP Status Code", not "HTTP Error" (authored by epriestley). · Explain WhyFeb 12 2019, 10:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

storage/

HeraldWebhookRequest.php

2 lines

Diff 48108

View Options

src/applications/herald/storage/HeraldWebhookRequest.php

In Webhooks, label HTTP response codes as "HTTP Status Code", not "HTTP Error"ClosedPublicActions