Differential D20115

Add formal setup guidance warning that "feed.http-hooks" will be removed in a future version of Phabricator
ClosedPublic
Actions

Authored by epriestley on Feb 7 2019, 12:29 AM.

Details

Reviewers

amckinley

Commits

rP4fa5a2421ea5: Add formal setup guidance warning that "feed.http-hooks" will be removed in a…

Summary

Depends on D20114. This is on the way out, so make that explicitly clear.

Test Plan

Read setup issue and configuration option.

Diff Detail

Repository

rP Phabricator

Branch

hook2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21867
Build 29845: Run Core Tests
Build 29844: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 7 2019, 12:29 AM

Harbormaster completed remote builds in B21867: Diff 48027.Feb 7 2019, 12:31 AM

epriestley requested review of this revision.Feb 7 2019, 12:31 AM

epriestley added a child revision: D20121: Make the default behavior of getApplicationTransactionCommentObject() "return null" instead of "throw".Feb 7 2019, 3:43 AM

amckinley accepted this revision.Feb 7 2019, 8:24 PM

This revision is now accepted and ready to land.Feb 7 2019, 8:24 PM

Closed by commit rP4fa5a2421ea5: Add formal setup guidance warning that "feed.http-hooks" will be removed in a… (authored by epriestley). · Explain WhyFeb 7 2019, 10:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorExtraConfigSetupCheck.php

18 lines

feed/

config/

PhabricatorFeedConfigOptions.php

26 lines

Diff 48027

View Options

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php