Differential D20081

Let omnipotent actors skip MFA transactions
ClosedPublic
Actions

Authored by epriestley on Feb 1 2019, 1:15 AM.

Tags

None

Referenced Files

	F14407580: D20081.diff
	Tue, Dec 24, 3:19 AM

	Unknown Object (File)
	Wed, Dec 18, 12:51 AM

	Unknown Object (File)
	Wed, Dec 18, 12:51 AM

	Unknown Object (File)
	Wed, Dec 18, 12:51 AM

	Unknown Object (File)
	Wed, Dec 18, 12:51 AM

	Unknown Object (File)
	Fri, Dec 13, 2:04 PM

	Unknown Object (File)
	Thu, Dec 12, 1:59 AM

	Unknown Object (File)
	Wed, Dec 4, 9:59 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rP7c795ab75722: Let omnipotent actors skip MFA transactions

Summary

This seems generally reasonable, but is also a narrow fix to "Phacility scripts try to move instances into 'up', but the daemons can't MFA".

Test Plan

Launched a new instance locally, no more "daemons can't MFA" error.

Diff Detail

Repository

rP Phabricator

Branch

omnimfa1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21795
Build 29741: Run Core Tests
Build 29740: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 1 2019, 1:15 AM

Harbormaster completed remote builds in B21795: Diff 47943.Feb 1 2019, 1:17 AM

epriestley requested review of this revision.Feb 1 2019, 1:17 AM

amckinley accepted this revision.Feb 1 2019, 7:00 PM

This revision is now accepted and ready to land.Feb 1 2019, 7:00 PM

Closed by commit rP7c795ab75722: Let omnipotent actors skip MFA transactions (authored by epriestley). · Explain WhyFeb 1 2019, 9:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

9 lines

Diff 47943

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Let omnipotent actors skip MFA transactionsClosedPublicActions