Differential D20081

Let omnipotent actors skip MFA transactions
ClosedPublic
Actions

Authored by epriestley on Feb 1 2019, 1:15 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 20, 4:31 PM

	Unknown Object (File)
	Fri, Apr 12, 2:54 PM

	Unknown Object (File)
	Wed, Mar 27, 5:14 PM

	Unknown Object (File)
	Wed, Mar 27, 5:14 PM

	Unknown Object (File)
	Wed, Mar 27, 5:14 PM

	Unknown Object (File)
	Wed, Mar 27, 5:14 PM

	Unknown Object (File)
	Mar 23 2024, 12:37 PM

	Unknown Object (File)
	Mar 23 2024, 12:37 PM

View All 72 Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rP7c795ab75722: Let omnipotent actors skip MFA transactions

Summary

This seems generally reasonable, but is also a narrow fix to "Phacility scripts try to move instances into 'up', but the daemons can't MFA".

Test Plan

Launched a new instance locally, no more "daemons can't MFA" error.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 1 2019, 1:15 AM

Harbormaster completed remote builds in B21795: Diff 47943.Feb 1 2019, 1:17 AM

epriestley requested review of this revision.Feb 1 2019, 1:17 AM

amckinley accepted this revision.Feb 1 2019, 7:00 PM

This revision is now accepted and ready to land.Feb 1 2019, 7:00 PM

Closed by commit rP7c795ab75722: Let omnipotent actors skip MFA transactions (authored by epriestley). · Explain WhyFeb 1 2019, 9:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

9 lines

Diff 47953

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Let omnipotent actors skip MFA transactionsClosedPublicActions