Page MenuHomePhabricator

Make repository daemons periodically check for out-of-sync repositories
ClosedPublic

Authored by epriestley on Jan 31 2019, 8:19 PM.
Tags
None
Referenced Files
F14651375: D20078.diff
Sat, Jan 11, 4:18 PM
Unknown Object (File)
Thu, Jan 9, 1:54 PM
Unknown Object (File)
Sat, Jan 4, 8:06 AM
Unknown Object (File)
Tue, Dec 24, 10:03 PM
Unknown Object (File)
Tue, Dec 24, 5:53 PM
Unknown Object (File)
Fri, Dec 20, 9:38 PM
Unknown Object (File)
Thu, Dec 19, 12:52 AM
Unknown Object (File)
Wed, Dec 18, 10:53 AM
Subscribers
None

Details

Summary

See PHI1015. If you add new repository nodes to a cluster, we may not actually sync some repositories for up to 6 hours (if they've had no commits for 30 days).

Add an explicit check for out-of-sync repositories to trigger background sync.

Test Plan
  • Ran bin/phd debug pullocal.
  • Fiddled with the repository_workingcopy version table to put the local node in and out of sync with the cluster.
  • Saw appropriate responses in the daemon (sync; wait if the last sync trigger was too recent).

Diff Detail

Repository
rP Phabricator
Branch
inactive2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21790
Build 29735: Run Core Tests
Build 29734: arc lint + arc unit

Event Timeline

src/applications/repository/management/PhabricatorRepositoryManagementWorkflow.php
10

This is a fix for PHP 7.3+ complaining about count(null) when you run bin/repository update with no arguments.

This revision is now accepted and ready to land.Feb 1 2019, 4:27 AM
This revision was automatically updated to reflect the committed changes.