Page MenuHomePhabricator

Make repository daemons periodically check for out-of-sync repositories
ClosedPublic

Authored by epriestley on Jan 31 2019, 8:19 PM.
Tags
None
Referenced Files
F12805346: D20078.id47948.diff
Wed, Mar 27, 5:13 PM
F12805340: D20078.id47938.diff
Wed, Mar 27, 5:13 PM
F12805333: D20078.id.diff
Wed, Mar 27, 5:13 PM
F12805331: D20078.diff
Wed, Mar 27, 5:13 PM
Unknown Object (File)
Sat, Mar 23, 12:37 PM
Unknown Object (File)
Sat, Mar 23, 12:37 PM
Unknown Object (File)
Sat, Mar 23, 12:37 PM
Unknown Object (File)
Sat, Mar 23, 12:37 PM
Subscribers
None

Details

Summary

See PHI1015. If you add new repository nodes to a cluster, we may not actually sync some repositories for up to 6 hours (if they've had no commits for 30 days).

Add an explicit check for out-of-sync repositories to trigger background sync.

Test Plan
  • Ran bin/phd debug pullocal.
  • Fiddled with the repository_workingcopy version table to put the local node in and out of sync with the cluster.
  • Saw appropriate responses in the daemon (sync; wait if the last sync trigger was too recent).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/repository/management/PhabricatorRepositoryManagementWorkflow.php
10

This is a fix for PHP 7.3+ complaining about count(null) when you run bin/repository update with no arguments.

This revision is now accepted and ready to land.Feb 1 2019, 4:27 AM
This revision was automatically updated to reflect the committed changes.