Differential D20065

Improve handling of "Deny" responses from Duo
ClosedPublic
Actions

Authored by epriestley on Jan 30 2019, 5:18 AM.

Details

Reviewers

amckinley

Maniphest Tasks

T13231: Duo MFA Support

Commits

rPe9b2d667ee57: Improve handling of "Deny" responses from Duo

Summary

Ref T13231. See https://discourse.phabricator-community.org/t/duo-integration-crashes-if-user-is-not-enrolled-and-enrollment-is-disabled/2340/5

(There's an actual bug here, although I'm not sure exactly what's going on on the Duo side in the report.)

Test Plan

To reproduce this, I was only able to actually "Deny" my account explicitly in Duo.

With "Deny", tried to add a factor. Got a nice helpful error message.
Undenied, added a factor, re-denied, tried to pass an MFA gate. Got another nice helpful error message.

Diff Detail

Repository

rP Phabricator

Branch

duo1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21778
Build 29719: Run Core Tests
Build 29718: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 30 2019, 5:18 AM

Harbormaster completed remote builds in B21756: Diff 47900.Jan 30 2019, 5:19 AM

epriestley requested review of this revision.Jan 30 2019, 5:19 AM

amckinley accepted this revision.Jan 31 2019, 2:45 AM

amckinley added inline comments.

src/applications/auth/factor/PhabricatorDuoAuthFactor.php
386–387	"The The"

This revision is now accepted and ready to land.Jan 31 2019, 2:45 AM

Typo fix.

Harbormaster completed remote builds in B21778: Diff 47928.Jan 31 2019, 3:30 AM

Closed by commit rPe9b2d667ee57: Improve handling of "Deny" responses from Duo (authored by epriestley). · Explain WhyJan 31 2019, 3:33 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

factor/

PhabricatorAuthFactor.php

14 lines

PhabricatorDuoAuthFactor.php

18 lines

Diff 47928

View Options

src/applications/auth/factor/PhabricatorAuthFactor.php