Page MenuHomePhabricator
Differential D20071

Hide "Signed with MFA" stories from feed
ClosedPublic
Actions

Authored by epriestley on Jan 30 2019, 11:01 PM.
Tags
None
Referenced Files
F14407532: D20071.diff
Tue, Dec 24, 3:08 AM
Unknown Object (File)
Mon, Dec 23, 1:46 AM
Unknown Object (File)
Sat, Dec 14, 8:22 PM
Unknown Object (File)
Fri, Dec 13, 5:44 AM
Unknown Object (File)
Wed, Dec 11, 5:51 AM
Unknown Object (File)
Sat, Dec 7, 1:11 AM
Unknown Object (File)
Tue, Dec 3, 11:17 AM
Unknown Object (File)
Thu, Nov 28, 6:12 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP612e9c6e09ad: Hide "Signed with MFA" stories from feed
Summary

See https://discourse.phabricator-community.org/t/sign-with-mfa-action-on-differential-revisions-creates-strange-feed-entries/2346.

If you "Sign with MFA" and only add a comment, we can produce a weird notification and feed story. Hide these stories from feed since they're broadly not interesting.

Test Plan
  • Used "sign with MFA" and only posted a comment.
  • Observed feed.
    • Before: Janky "untitled story".
    • After: Sensible "added a comment" story.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 30 2019, 11:01 PM
Harbormaster completed remote builds in B21771: Diff 47921.Jan 30 2019, 11:03 PM
epriestley requested review of this revision.Jan 30 2019, 11:03 PM
amckinley accepted this revision.Jan 31 2019, 2:46 AM
This revision is now accepted and ready to land.Jan 31 2019, 2:46 AM
Closed by commit rP612e9c6e09ad: Hide "Signed with MFA" stories from feed (authored by epriestley). · Explain WhyJan 31 2019, 3:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
storage/
3 lines

Diff 47925

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
Phabricator · Built by Phacility