Differential D20071

Hide "Signed with MFA" stories from feed
ClosedPublic
Actions

Authored by epriestley on Jan 30 2019, 11:01 PM.

Details

Reviewers

Commits

rP612e9c6e09ad: Hide "Signed with MFA" stories from feed

Summary

See https://discourse.phabricator-community.org/t/sign-with-mfa-action-on-differential-revisions-creates-strange-feed-entries/2346.

If you "Sign with MFA" and only add a comment, we can produce a weird notification and feed story. Hide these stories from feed since they're broadly not interesting.

Test Plan

Used "sign with MFA" and only posted a comment.
Observed feed.
- Before: Janky "untitled story".
- After: Sensible "added a comment" story.

Diff Detail

Repository

rP Phabricator

Branch

mfa1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21771
Build 29710: Run Core Tests
Build 29709: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 30 2019, 11:01 PM

Harbormaster completed remote builds in B21771: Diff 47921.Jan 30 2019, 11:03 PM

epriestley requested review of this revision.Jan 30 2019, 11:03 PM

amckinley accepted this revision.Jan 31 2019, 2:46 AM

This revision is now accepted and ready to land.Jan 31 2019, 2:46 AM

Closed by commit rP612e9c6e09ad: Hide "Signed with MFA" stories from feed (authored by epriestley). · Explain WhyJan 31 2019, 3:26 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

storage/

PhabricatorApplicationTransaction.php

3 lines

Diff 47921

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Hide "Signed with MFA" stories from feedClosedPublicActions