Page MenuHomePhabricator
Differential D20072

Update a factor query in TransactionEditor for providers
ClosedPublic
Actions

Authored by epriestley on Jan 30 2019, 11:05 PM.
Tags
None
Referenced Files
F15431842: D20072.id47922.diff
Mon, Mar 24, 2:50 PM
F15406552: D20072.diff
Tue, Mar 18, 12:40 PM
F15401262: D20072.id.diff
Mon, Mar 17, 4:37 PM
F15336101: D20072.id47927.diff
Sat, Mar 8, 6:14 PM
F15336099: D20072.id.diff
Sat, Mar 8, 6:14 PM
F15336098: D20072.diff
Sat, Mar 8, 6:14 PM
Unknown Object (File)
Feb 1 2025, 12:24 AM
Unknown Object (File)
Jan 29 2025, 1:44 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP93b512b63cca: Update a factor query in TransactionEditor for providers
Summary

This query didn't get updated and could let you through an explicit "Sign with MFA" action if you have only disabled factors on your account.

Test Plan
  • Disabled all factors.
  • Used explicit "Sign With MFA".
    • Before: Went through.
    • After: Sensible error.

Diff Detail

Repository
rP Phabricator
Branch
mfa2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21772
Build 29712: Run Core Tests
Build 29711: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
editor/
12 lines

Diff 47922

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility