Page MenuHomePhabricator
Differential D20072

Update a factor query in TransactionEditor for providers
ClosedPublic
Actions

Authored by epriestley on Jan 30 2019, 11:05 PM.
Tags
None
Referenced Files
F13089123: D20072.diff
Thu, Apr 25, 1:40 AM
Unknown Object (File)
Mon, Apr 22, 12:34 AM
Unknown Object (File)
Fri, Apr 12, 6:08 PM
Unknown Object (File)
Thu, Apr 11, 9:30 AM
Unknown Object (File)
Mon, Apr 8, 8:57 PM
Unknown Object (File)
Sun, Apr 7, 12:15 AM
Unknown Object (File)
Fri, Mar 29, 6:15 AM
Unknown Object (File)
Wed, Mar 27, 5:23 PM
View All 80 Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP93b512b63cca: Update a factor query in TransactionEditor for providers
Summary

This query didn't get updated and could let you through an explicit "Sign with MFA" action if you have only disabled factors on your account.

Test Plan
  • Disabled all factors.
  • Used explicit "Sign With MFA".
    • Before: Went through.
    • After: Sensible error.

Diff Detail

Repository
rP Phabricator
Branch
mfa2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21772
Build 29712: Run Core Tests
Build 29711: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
editor/
12 lines

Diff 47922

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility