See D20039. Although http_build_query() works fine for the most part, it does the wrong thing by default if arg_separator.output is set in configuration.
Provide a wrapper which forces the expected behavior.
Details
Details
Ran unit tests.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- http1
- Lint
Lint Errors Severity Location Code Message Error src/utils/utils.php:1317 XHP45 PHP Compatibility Error src/utils/utils.php:1317 XHP45 PHP Compatibility - Unit
Tests Passed - Build Status
Buildable 21729 Build 29648: Run Core Tests Build 29647: arc lint + arc unit
Event Timeline
| src/markup/engine/remarkup/blockrule/PhutilRemarkupTestInterpreterRule.php | ||
|---|---|---|
| 14 | HA HA HA THIS TEST WOULD PREVIOUSLY FAIL UNDER UNUSUAL VALUES OF arg_separator.output HA HA HA PHP | |
| src/parser/PhutilURI.php | ||
|---|---|---|
| 177 | Ah, thanks! | |
Comment Actions
- Switch to PHP_QUERY_RFC3986 mode.
- Add unit tests.
This corresponds to rawurlencode(). The default mode (PHP_QUERY_RFC1738) corresponds to urlencode().
The only differences for this new mode are:
- Space is encoded as %20 (instead of +).
- "~" is not encoded (instead of %7F).
The space encoding as %20 seems strongly preferable, since any reasonable parser can and should handle it unambiguously, while the meaning of + to parsers is ambiguous.
This is also what Duo (at least) expects, and what we'd expect ourselves.
Comment Actions
- Use rawurlencode(), not http_build_query(), because PHP_QUERY_RFC3986 requires PHP 5.4 or newer.