Page MenuHomePhabricator
Differential D19977

Don't require "CAN_EDIT" to watch/unwatch a project
ClosedPublic
Actions

Authored by epriestley on Jan 16 2019, 1:55 PM.
Tags
None
Referenced Files
F14795711: D19977.id47703.diff
Sat, Jan 25, 3:11 AM
F14795710: D19977.id47679.diff
Sat, Jan 25, 3:11 AM
F14795708: D19977.id.diff
Sat, Jan 25, 3:10 AM
Unknown Object (File)
Tue, Jan 21, 10:07 AM
Unknown Object (File)
Fri, Jan 10, 1:11 AM
Unknown Object (File)
Thu, Jan 9, 11:56 PM
Unknown Object (File)
Thu, Jan 9, 3:25 PM
Unknown Object (File)
Sat, Jan 4, 5:10 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP966a93334c85: Don't require "CAN_EDIT" to watch/unwatch a project
Summary

See T1024. When "CAN_EDIT" became default in T13186, this was missed as an exception.

Watching shouldn't require "CAN_EDIT", so exempt it.

Test Plan
  • Before change: tried to watch a project I could not edit, got a policy error.
  • After change: watched/unwatched a project I could not edit.

Diff Detail

Repository
rP Phabricator
Branch
watch1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21532
Build 29345: Run Core Tests
Build 29344: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
editor/
3 lines

Diff 47679

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility