Page MenuHomePhabricator
Differential D19977

Don't require "CAN_EDIT" to watch/unwatch a project
ClosedPublic
Actions

Authored by epriestley on Jan 16 2019, 1:55 PM.
Tags
None
Referenced Files
F19033595: D19977.diff
Tue, Nov 25, 11:15 AM
F19033584: D19977.diff
Tue, Nov 25, 11:10 AM
F18853061: D19977.id.diff
Fri, Oct 31, 1:59 PM
F18849850: D19977.diff
Oct 30 2025, 12:31 PM
F18822900: D19977.id47679.diff
Oct 23 2025, 9:11 AM
F18815923: D19977.id.diff
Oct 21 2025, 4:15 AM
F18764726: D19977.diff
Oct 7 2025, 7:35 AM
F18674230: D19977.id.diff
Sep 25 2025, 1:43 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP966a93334c85: Don't require "CAN_EDIT" to watch/unwatch a project
Summary

See T1024. When "CAN_EDIT" became default in T13186, this was missed as an exception.

Watching shouldn't require "CAN_EDIT", so exempt it.

Test Plan
  • Before change: tried to watch a project I could not edit, got a policy error.
  • After change: watched/unwatched a project I could not edit.

Diff Detail

Repository
rP Phabricator
Branch
watch1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21532
Build 29345: Run Core Tests
Build 29344: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
editor/
3 lines

Diff 47679

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility