Page MenuHomePhabricator

Don't require "CAN_EDIT" to watch/unwatch a project
ClosedPublic

Authored by epriestley on Jan 16 2019, 1:55 PM.
Tags
None
Referenced Files
F13300822: D19977.diff
Fri, Jun 7, 10:23 AM
F13287297: D19977.diff
Tue, Jun 4, 8:35 AM
F13274581: D19977.diff
Fri, May 31, 3:52 AM
F13260642: D19977.diff
Mon, May 27, 12:11 AM
F13242984: D19977.diff
Thu, May 23, 3:15 AM
F13221386: D19977.diff
Sun, May 19, 2:44 AM
F13203761: D19977.diff
Wed, May 15, 12:06 AM
F13186306: D19977.diff
Sat, May 11, 3:33 AM
Subscribers
None

Details

Summary

See T1024. When "CAN_EDIT" became default in T13186, this was missed as an exception.

Watching shouldn't require "CAN_EDIT", so exempt it.

Test Plan
  • Before change: tried to watch a project I could not edit, got a policy error.
  • After change: watched/unwatched a project I could not edit.

Diff Detail

Repository
rP Phabricator
Branch
watch1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21532
Build 29345: Run Core Tests
Build 29344: arc lint + arc unit