Page MenuHomePhabricator

Don't require "CAN_EDIT" to watch/unwatch a project
ClosedPublic

Authored by epriestley on Jan 16 2019, 1:55 PM.
Tags
None
Referenced Files
F14614927: D19977.diff
Thu, Jan 9, 3:25 PM
Unknown Object (File)
Sat, Jan 4, 5:10 PM
Unknown Object (File)
Mon, Dec 30, 3:44 AM
Unknown Object (File)
Fri, Dec 20, 10:24 PM
Unknown Object (File)
Sat, Dec 14, 12:26 PM
Unknown Object (File)
Dec 9 2024, 5:41 PM
Unknown Object (File)
Dec 9 2024, 2:56 PM
Unknown Object (File)
Dec 8 2024, 4:39 PM
Subscribers
None

Details

Summary

See T1024. When "CAN_EDIT" became default in T13186, this was missed as an exception.

Watching shouldn't require "CAN_EDIT", so exempt it.

Test Plan
  • Before change: tried to watch a project I could not edit, got a policy error.
  • After change: watched/unwatched a project I could not edit.

Diff Detail

Repository
rP Phabricator
Branch
watch1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21532
Build 29345: Run Core Tests
Build 29344: arc lint + arc unit