Page MenuHomePhabricator
Differential D19968

Fix an issue where transactions in mail were always rendered as text
ClosedPublic
Actions

Authored by epriestley on Jan 14 2019, 7:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 20, 2:05 AM
Unknown Object (File)
Sun, Feb 9, 6:54 AM
Unknown Object (File)
Sun, Feb 9, 6:54 AM
Unknown Object (File)
Sun, Feb 9, 6:54 AM
Unknown Object (File)
Sun, Feb 9, 6:54 AM
Unknown Object (File)
Tue, Jan 28, 4:34 AM
Unknown Object (File)
Tue, Jan 28, 4:34 AM
Unknown Object (File)
Tue, Jan 28, 4:34 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T12921: Link to referenced object in transaction emails
Commits
rP0c0cbb1c09e4: Fix an issue where transactions in mail were always rendered as text
Summary

Fixes T12921. Currently, we call getTitleForHTMLMail(), but that calls getTitleForMail() which forces us into text rendering mode.

Instead, have getTitleForHTML/TextMail() force the rendering mode, then call getTitleForMail() with the desired rendering mode.

This causes stories like "epriestely added dependent tasks: x, y." to appear as links in email instead of plain text.

Test Plan

Used bin/mail show-outbound --id ... --dump-html > out.html to verify HTML mail.

Diff Detail

Repository
rP Phabricator
Branch
mfa12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21517
Build 29317: Run Core Tests
Build 29316: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 14 2019, 7:31 PM
Harbormaster completed remote builds in B21516: Diff 47663.Jan 14 2019, 7:33 PM
epriestley requested review of this revision.Jan 14 2019, 7:33 PM
epriestley updated this revision to Diff 47664.Jan 14 2019, 7:34 PM
  • Slightly simpler implementation.
Harbormaster completed remote builds in B21517: Diff 47664.Jan 14 2019, 7:36 PM
amckinley accepted this revision.Jan 16 2019, 2:10 AM
This revision is now accepted and ready to land.Jan 16 2019, 2:10 AM
Closed by commit rP0c0cbb1c09e4: Fix an issue where transactions in mail were always rendered as text (authored by epriestley). · Explain WhyJan 16 2019, 9:21 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T13222: 2018 Week 48-51 Bonus Content.Jan 19 2019, 4:20 AM
epriestley mentioned this in T12921: Link to referenced object in transaction emails.Jan 19 2019, 1:08 PM
epriestley mentioned this in rP755c40221d5f: Temporarily disable transaction story links in HTML mail for the deploy.Jan 19 2019, 1:10 PM
epriestley mentioned this in rPca77d3572fcb: (stable) Temporarily disable transaction story links in HTML mail for the deploy.

Revision Contents
Changeset List

Diff 47664

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorModularTransaction.php

Loading...
Phabricator · Built by Phacility