Page MenuHomePhabricator

Remove Twilio-PHP API external
ClosedPublic

Authored by epriestley on Jan 2 2019, 3:16 AM.
Tags
None
Referenced Files
F15421177: D19938.diff
Fri, Mar 21, 9:27 PM
F15420593: D19938.largetrue.diff
Fri, Mar 21, 3:15 PM
F15417379: D19938.id47600.diff
Thu, Mar 20, 4:45 PM
F15402670: D19938.id47611.diff
Mon, Mar 17, 11:39 PM
F15388977: D19938.id.diff
Sat, Mar 15, 4:46 AM
F15367845: D19938.id47611.diff
Tue, Mar 11, 9:21 PM
Unknown Object (File)
Fri, Feb 28, 1:33 PM
Unknown Object (File)
Fri, Feb 28, 1:33 PM
Subscribers

Details

Summary

Ref T920. D19937 provides about 100 lines of code which can do essentially everything here; throw out the trillion lines of full external API stuff.

(I am generally not sure why everyone writes API libraries like this instead of like D19937.)

Test Plan

Send SMS messages with D19937, so I don't think we need any of this code anymore. This code is techncially reachable through some pathways like bin/sms, but won't be for long.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable