Page MenuHomePhabricator

Remove Twilio-PHP API external
ClosedPublic

Authored by epriestley on Jan 2 2019, 3:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 7:11 AM
Unknown Object (File)
Fri, Apr 19, 3:50 AM
Unknown Object (File)
Wed, Apr 17, 3:32 PM
Unknown Object (File)
Wed, Apr 17, 12:46 PM
Unknown Object (File)
Sun, Apr 14, 1:43 PM
Unknown Object (File)
Wed, Apr 10, 3:20 PM
Unknown Object (File)
Sun, Mar 31, 11:33 PM
Unknown Object (File)
Thu, Mar 21, 10:44 PM
Subscribers

Details

Summary

Ref T920. D19937 provides about 100 lines of code which can do essentially everything here; throw out the trillion lines of full external API stuff.

(I am generally not sure why everyone writes API libraries like this instead of like D19937.)

Test Plan

Send SMS messages with D19937, so I don't think we need any of this code anymore. This code is techncially reachable through some pathways like bin/sms, but won't be for long.

Diff Detail

Repository
rP Phabricator
Branch
mfa4
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 21454
Build 29215: Run Core Tests
Build 29214: arc lint + arc unit